feat: add couchbase, dynamodb and mongodbspringdata marker#902
Merged
dieppa merged 4 commits intoMay 18, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Wires the Couchbase, DynamoDB and MongoDB Spring Data target systems to use real audit markers (instead of the NoOpTargetSystemAuditMarker) when the Flamingock edition is not COMMUNITY, introduces a new MongoDBSpringDataAuditMarker, and re-enables related rollback tests.
Changes:
- Select
NoOpTargetSystemAuditMarkervs real marker based onFlamingockEditionin Couchbase, DynamoDB and MongoDB Spring Data target systems, replacing prior TODOs. - Add new
MongoDBSpringDataAuditMarkerthat writes viaMongoTemplate.getDb()to participate in Spring-managed Mongo transactions, plus a Couchbase tx supplier that throws if accessed outsidecluster.transactions().run(). - Re-enable previously disabled
failedChanges(and DynamohappyPathongoing-status) tests, drop marker collections/tables inafterEach, and reorderverifyAllCallsto run after the failingrunner.run().
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| core/target-systems/flamingock-couchbase-targetsystem/src/main/java/io/flamingock/targetsystem/couchbase/CouchbaseTargetSystem.java | Select Couchbase audit marker by edition and add explicit-failure supplier for TransactionAttemptContext. |
| core/target-systems/flamingock-couchbase-targetsystem/src/test/java/io/flamingock/targetsystem/couchbase/CouchbaseTargetSystemTest.java | Drop marker collection in teardown, re-enable rollback assertions, reorder verifyAllCalls. |
| core/target-systems/flamingock-dynamodb-targetsystem/src/main/java/io/flamingock/targetsystem/dynamodb/DynamoDBTargetSystem.java | Select DynamoDB audit marker by edition (default COMMUNITY). |
| core/target-systems/flamingock-dynamodb-targetsystem/src/test/java/io/flamingock/targetsystem/dynamodb/DynamoDBCloudTargetSystemTest.java | Drop marker tables in teardown, re-enable rollback/ongoing-status checks. |
| core/target-systems/flamingock-dynamodb-targetsystem/src/test/java/io/flamingock/targetsystem/dynamodb/DynamoDBTestHelper.java | Add dropTable helper that ignores ResourceNotFoundException. |
| core/target-systems/flamingock-mongodb-springdata-targetsystem/src/main/java/io/flamingock/targetsystem/mongodb/springdata/MongoDBSpringDataAuditMarker.java | New audit marker relying on session-aware MongoTemplate.getDb(). |
| core/target-systems/flamingock-mongodb-springdata-targetsystem/src/main/java/io/flamingock/targetsystem/mongodb/springdata/MongoDBSpringDataTargetSystem.java | Select Spring Data audit marker by edition. |
| core/target-systems/flamingock-mongodb-springdata-targetsystem/src/test/java/io/flamingock/targetsystem/mongodb/springdata/MongoDBSpringDataTargetSystemTest.java | Drop marker collection in teardown, re-enable rollback assertions, reorder verifyAllCalls. |
| core/target-systems/flamingock-mongodb-sync-targetsystem/src/test/java/io/flamingock/targetsystem/mongodb/sync/MongoDBSyncTargetSystemTest.java | Drop marker collection in teardown, re-enable rollback assertions, reorder verifyAllCalls. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
36
| import java.util.function.Supplier; | ||
|
|
||
| import java.util.Objects; | ||
| import java.util.Optional; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add couchbase, dynamodb and mongodbspringdata marker